On Wed, 3 Feb 2021 22:30:02 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add key itself to signature verification > > test/jdk/sun/security/provider/NSASuiteB/TestDSAGenParameterSpecLongKey.java > line 30: > >> 28: * DSA within some certain range of key sizes as described in >> the class >> 29: * specification (L, N) as (1024, 160), (2048, 224), (2048, >> 256) and >> 30: * (3072, 256) should be OK for DSAGenParameterSpec. > > Please modify the `@summary` to match what this test does. sure, short description about this change was added to summary > test/jdk/sun/security/rsa/SignatureTest.java line 145: > >> 143: Asserts.assertTrue(keySpecEquals(pubKeySpec1, >> pubKeySpec2), >> 144: "Both RSAPublicKeySpec should be equal"); >> 145: > > Do you also want to add similar check on X509EncodedKeySpec? Same for > PKCS8EncodedKeySpec below. Both verifications included now ------------- PR: https://git.openjdk.java.net/jdk/pull/2381
