On Thu, 11 Feb 2021 01:54:53 GMT, John Jiang <[email protected]> wrote:
>> This is a simple cleanup for sun.security.ssl.SSLExtension.
>> It converts protocol or draft names to RFC numbers correspondingly.
>> It also removes a trailing space in extension token_binding, and move
>> signature_algorithms_cert to RFC 8446 extension group.
>
> John Jiang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed Xuelei's comment
I agree with previous suggestion, but could you do throughout the file? Having
something like either:
// extension defined in RFC 7301 (ALPN)
// extension defined in ALPN (RFC 7301)
throughout this file is encouraged and appreciated. Having the RFC #/short
name of the document would be a lot more readable, rather than having to look
up the RFC for a synopsis. e.g.
// extensions defined in RFC 8472
->
// extensions defined in Token Binding Protocol Negotiation (RFC 8472)
or
// extensions defined in RFC 8472 (Token Binding Protocol Negotiation)
I noticed the previous comment for TLS1.3 wasn't fully addressed (line 314).
-------------
PR: https://git.openjdk.java.net/jdk/pull/2517
