On Tue, 16 Feb 2021 22:13:05 GMT, Hai-May Chao <hc...@openjdk.org> wrote:

>> This change is made for compliance with RFC 5280 section 4.2.1.1 for 
>> Authority Key Identifier extension.
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Compare keys using encoded bytes

Looks good. However, I think you should change the title of the bug to be more 
descriptive, which will help for release notes, etc. How about: "Update keytool 
to create AKID from the SKID of the issuing certificate as specified by RFC 
5280."

-------------

Marked as reviewed by mullan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2343

Reply via email to