On Mon, 22 Feb 2021 18:56:10 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Jamil Nimeh has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary import > > test/jdk/sun/security/ssl/SignatureScheme/SigSchemePropOrdering.java line 90: > >> 88: private static final String SIG_SCHEME_STR = >> 89: "rsa_pkcs1_sha256,rsa_pss_rsae_sha256,rsa_pss_pss_sha256," + >> 90: "ed448,ed25519,ecdsa_secp256r1_sha256"; > > It have been a while that we are trying to avoid the use the binary keystore > files in test. It would be nice that if new test cases could use the > javax/net/ssl/templates/javax/net/ssl/templates instead. I should be able to rework it into an extension of SSLEngineTemplate. > src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 387: > >> 385: config.signatureSchemes.isEmpty() ? >> 386: Arrays.asList(SignatureScheme.values()) : >> 387: config.signatureSchemes; > > I would like to have two more indents for the '?' operator. No problem, will do. ------------- PR: https://git.openjdk.java.net/jdk/pull/2658
