On Tue, 2 Mar 2021 17:26:15 GMT, Ziyi Luo <luoz...@openjdk.org> wrote:
>> All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be >> backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most >> cases, the requested KeySpec is equal to the concrete implementation so the >> inversion does not matter. But there are few cases, as presented in the >> added jtreg test, will cause unexpected behavior (e.g., ClassCastException >> rather than an InvalidKeySpecException). The fix is trivial. >> >> Co-author @SalusaSecondus > > Ziyi Luo has updated the pull request incrementally with one additional > commit since the last revision: > > 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear > to be backwards (r2) Thanks for fixing those two tests and the nits. Looks good. ------------- Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2682
