On Fri, 12 Mar 2021 16:29:34 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 additional >> commits since the last revision: >> >> - Merge branch 'master' into 8255255 >> - reapply 8259535: ECDSA SignatureValue do not always have the specified >> length >> - No more newInstance calls >> - Reapply 8255559: Leak File Descriptors Because of >> ResolverLocalFilesystem#engineResolveURI() >> - Fix test failures >> - Supporting named RSASSA-PSS without parameters >> - Reapply 8008744: Rework part of fix for JDK-6741606 >> - Reapply 8151893: Add security property to configure XML Signature secure >> validation mode >> >> Reapply 8140353: Improve signature checking >> - Reapply Reapply 8042967: Add variant of DSA Signature algorithms that do >> not ASN.1 encode the signature bytes >> - Reapply 8038913: Bolster XML support (Init.java part) >> - ... and 5 more: >> https://git.openjdk.java.net/jdk/compare/f285a525...60496847 > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java > line 70: > >> 68: * @return the Set of Nodes >> 69: */ >> 70: static Set<Node> toNodeSet(Iterator<?> i) { > > Why does `Iterator<Node>` cause a warning? It's called at https://github.com/wangweij/jdk/blob/604968474ac20abae1d65a5c00053c76a47c559a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java#L159 where there is no template parameter. ------------- PR: https://git.openjdk.java.net/jdk/pull/1206
