On Wed, 17 Mar 2021 20:09:04 GMT, Valerie Peng <valer...@openjdk.org> wrote:

>> Can someone help review this somewhat trivial change?
>> 
>> Updated JCAUtil class to return the cached SecureRandom object only when the 
>> provider configuration has not changed. 
>> Added a regression test to check the affected classes, i.e. 
>> AlgorithmParameterGenerator, KeyPairGenerator, Cipher, KeyAgreement, 
>> KeyGenerator. 
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fixed a null race condition

Not that my review counts towards approval, but this looks good to me (and 
fixes some issues I've been wrestling with on and off for several years now, so 
I'm really happy to see this change).

-------------

Marked as reviewed by salusasecon...@github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk/pull/3018

Reply via email to