On Tue, 23 Feb 2021 20:40:05 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi, >> >> I need a code review of this change to ECDH. It is a combination of fixing >> the implementation to not only accept ECPrivateKeyImpl along with a fix to >> the exception handling. They started as two fixes, but with the exception >> handling the underlying code changed significantly that made the >> ECPrivateKey change in a different place. The new exception handling is a >> result of no longer having the native library. Many of the checks waited >> until generateSecret() to send the keys to the native library. Now that >> native is gone, checks can happen when keys are provided to the methods and >> proper exceptions can be thrown instead of wrapping everything as a >> ProviderException >> >> thanks, >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > Simpler fix for ECPrivateKey test/jdk/com/sun/crypto/provider/KeyAgreement/ECKeyCheck.java line 27: > 25: * @test > 26: * @bug 8238911 > 27: * @summary Check that ECPrivateKey's that are not ECPrivateKeyImpl can > use Do the bug and summary tags need to be updated to 8261502 and "ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling", respectively? ------------- PR: https://git.openjdk.java.net/jdk/pull/2659
