On Wed, 24 Mar 2021 03:25:02 GMT, Ziyi Luo <luoz...@openjdk.org> wrote:
>> This is a P2 regression introduced by JDK-8254717. >> >> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the >> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is >> described as follow: >> >> X-axis: type of `keySpec` >> Y-axis: type of `key` >> >> Before JDK-8254717: >> >> | | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class | >> |--|--|--| >> | RSAPrivateKey | Return RSAPrivateKeySpec | Throw >> `InvalidKeySpecException` | >> | RSAPrivateCrtKey | Return RSAPrivateKeySpec | Return RSAPrivateKeyCrtSpec | >> >> After JDK-8254717 (Green check is what we want to fix, red cross is the >> regression): >> >> | | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class | >> |--|--|--| >> | RSAPrivateKey | Throw `InvalidKeySpecException` ❌ | Throw >> `InvalidKeySpecException` | >> | RSAPrivateCrtKey | Return RSAPrivateKeyCrtSpec ✅ | Return >> RSAPrivateKeyCrtSpec | >> >> This commit fixes the regression. >> >> >> ### Tests >> >> * Jtreg: All tests under `java/security`, `sun/security`, `javax/crypto` >> passed >> * JCK: All JCK-16 (I do not have jCK-17)tests under `api/java_security` >> passed > > Ziyi Luo has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove trailing whitespace > - Refactor P11RSAKeyFactory and improve tests src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java line 285: > 283: // If the key is both extractable and not sensitive, then when > it was converted into a P11Key > 284: // it was also converted into subclass of RSAPrivateKey which > encapsulates all of the logic > 285: // necessary to retrive the attributes we need. This sub-class > will also cache these attributes nit: retrieve ------------- PR: https://git.openjdk.java.net/jdk/pull/2949
