On Mon, 29 Mar 2021 18:45:47 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve JdkServer::close and Utilities::waitFor methods > > test/jdk/javax/net/ssl/TLSCommon/interop/BaseInteropTest.java line 236: > >> 234: // Retry operation, server might have failed to bind a port >> 235: server.signalStop(); >> 236: server = createServer(useCase, executor); > > Can you please define MAX_RETRIES and use loop to retry? This will make it > flexible for us to update retries if needed and avoid duplicate code. Done, also retries value can be now overridden by subclasses if we wanted. In addition, moved Utilities::shell and shellProc to ProcUtils class which is a better location and added support for running win commands ------------- PR: https://git.openjdk.java.net/jdk/pull/3218
