On Tue, 30 Mar 2021 20:24:49 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> I wonder if the @implSpec is clear enough that this will be returned. I >> might suggest adding a similar @implSpec in this method that basically >> states what you said above. > > I'm not sure if it's appropriate to specify the default value in this method. > As long as there is an `RSAPSSParameterSpec` object, there must be a non-null > `PSSParameterSpec` inside and it is the one that was used to construct this > object. > > I am thinking if we can append the following to the `@implSpec` in the class > spec: > * One can obtain this default value using the following expression: > * <pre><code> > * XMLSignatureFactory.getInstance() > * .newSignatureMethod(SignatureMethod.RSA_PSS, null) > * .getParameterSpec() > * </code></pre> > > but this makes it more like an `@implNote` instead of an `@implSpec`. I added the new lines as `@implNote` and kept the old `@implSpec` there (since it's still a requirement for implementations). New commit pushed. CSR updated as well. ------------- PR: https://git.openjdk.java.net/jdk/pull/3181
