On Fri, 9 Apr 2021 16:47:55 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, and comments are welcome > [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)]. Marked as reviewed by joehw (Reviewer). src/java.base/share/classes/java/io/Console.java line 404: > 402: * > 403: * @return A {@code Charset} object used in this {@code Console}. > 404: * @since 17 A couple of minor comments: May replace {@code Charset} with @link; Add "the" to the sentence: The returned charset corresponds to "the" input... @return: javadoc guide suggests "do not capitalize and do not end with a period" when writing a phrase. But I guess for consistency in this class, it's okay to capitalize. ------------- PR: https://git.openjdk.java.net/jdk/pull/3419
