On Thu, 8 Apr 2021 17:02:20 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> 8264681: Use the blessed modifier order in java.security > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java > line 390: > >> 388: } >> 389: >> 390: public abstract PSSParameterSpec getPSSParameterSpec(); > > This is 3rd-party (Apache) code. It would be better to change this at Apache. > I would leave this one out. @alblue, this is the unresolved comment. Please fix it? > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Constants.java > line 53: > >> 51: >> 52: /** >> 53: * This class holds only static final member variables that are constants > > Probably best to leave this file unchanged as it is 3rd-party code. Same here... ------------- PR: https://git.openjdk.java.net/jdk/pull/3338
