On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon <pconcan...@openjdk.org> wrote:
> Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Two comments: 1. Why not reuse the existing variable name (Ex: `t` in `Type t = (Type)obj`) as much as possible to avoid unnecessary renames? 2. I'm not sure if modifying argument name in a public API is a good idea. This leads to unnecessary javadoc changes. ------------- PR: https://git.openjdk.java.net/jdk/pull/3687
