On Tue, 4 May 2021 08:12:23 GMT, Alan Bateman <[email protected]> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert bad change in benchmark copyright
>> - Do not apply optimized bound check if accessed offset/length do not fit
>> in an `int` value
>
> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java
> line 34:
>
>> 32: import java.util.Set;
>> 33:
>> 34: public final class IllegalNativeAccessChecker {
>
> Are you sure about the name of the this class? It doesn't do any checking and
> it's not concerned with "illegal native access" either, instead it just
> provides access to the names of modules that have been granted native access.
I've decided to drop this class and move the logic in ModuleBootstrap. To
handle unnamed modules, I had to piggy back on the special static ALL_UNNAMED
module and set the flag there when decoding the command line option. This seems
to be consistent with what is done in other areas.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3699
