On Wed, 19 May 2021 20:21:23 GMT, Anthony Scarpino <ascarp...@openjdk.org>
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and make some
>> performance-based decisions.
>>
>> Thanks
>>
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix perf problem by reorganizing doLastBlock()
src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line
59:
> 57: final class GaloisCounterMode extends FeedbackCipher {
> 58:
> 59: static int DEFAULT_TAG_LEN = AES_BLOCK_SIZE;
Hmm, for the same reason as the DEFAULT_IV_LEN, you will probably need a
DEFAULT_TAG_LEN. Otherwise, how do you know what the default tag length is
after several Cipher.init() calls?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4072
