On Tue, 18 May 2021 13:19:53 GMT, Fernando Guallini <fguall...@openjdk.org> wrote:
> Refactor the following shell tests to Java: > - security/pkcs11/KeyStore/Basic.sh > - security/pkcs11/KeyStore/ClientAuth.sh > - security/pkcs11/KeyStore/SecretKeysBasic.sh > - security/pkcs11/Provider/ConfigQuotedString.sh > - security/pkcs11/Provider/Login.sh > - security/pkcs11/Config/ReadConfInUTF16Env.sh > > Currently, most of the shell tests in the list may be ignored during > execution time in most platforms since they are incorrectly filtered out by > the OS name they are run on. For example, ClientAuth.sh is only run if the OS > name is equal to ‘Linux’, but OS name may also include the architecture such > as ‘Linux x86_64’. Those platform constraints are removed in this PR. > > Additionally, further changes are introduced in the following test: > > - ClientAuth: it was failing intermittently because the server side was > binding to the wildcard address. The issue is fixed by binding to loopback > address instead. Also, Thread.sleep is replaced with CountdownLatch to > facilitate synchronization between client and server. Finally, a new ‘user1’ > certificate was generated since the current one has expired. > > - Basic: Remove redundant X509Certificate casting > > - SecretKeysBasic: it was already in the problem list since it reproduces the > open bug JDK-8209398 and fails. Test is refactored to java and still > reproduces the issue. > > All the mentioned tests were run many times in multiple platforms to ensure > stability This pull request has now been integrated. Changeset: ccfcd926 Author: Fernando Guallini <fguall...@openjdk.org> Committer: Xue-Lei Andrew Fan <xue...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/ccfcd926674ee0bd88f34b16b489abe008169b11 Stats: 1076 lines in 18 files changed: 195 ins; 820 del; 61 mod 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures Reviewed-by: xuelei ------------- PR: https://git.openjdk.java.net/jdk/pull/4092
