On Wed, 16 Jun 2021 18:10:05 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11AEADCipher.java
>> line 365:
>>
>>> 363: default:
>>> 364: // should never happen; checked by Cipher.init()
>>> 365: throw new AssertionError("Unknown mode: " + opmode);
>>
>> This update looks good to me. But there is a potential issues, maybe for
>> all switch statements. If the cipher modes is extended to support more
>> items, we may have to look for and update all the switch uses and make sure
>> there is no broken. Anyway, for my personal understanding, there is nothing
>> we could do right now.
>
> Right, if new modes are added, we need to go through all cipher impl and
> update the switch statements. This change is just to make sure our handling
> is consistent.
Thanks much for the review~
-------------
PR: https://git.openjdk.java.net/jdk17/pull/69
