On Fri, 18 Jun 2021 06:06:01 GMT, Sibabrata Sahoo <ssa...@openjdk.org> wrote:
>> Abdul Kolarkunnu has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8266182: Create a manual test for jdk/sun/security/pkcs12/ParamsTest.java
>
> test/jdk/sun/security/pkcs12/KeytoolOpensslInterop.sh line 25:
>
>> 23:
>> 24: # Use OpenSSL 1.1.0i or above versions, earlier versions may generate
>> different
>> 25: # info and test fail.
>
> It will be more helpful, if some instruction given about finding openssl, any
> pre-post requirement and any specific way to validate the result after
> execution for this manual Test execution.
Added more details.
> test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 43:
>
>> 41: */
>> 42:
>> 43: public class KeytoolOpensslInteropTest {
>
> This file is not necessary and the shell script can have @run tag instead.
Yes, corrected that way. Removed this file and done everything in the shell
script.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4413
