On Tue, 22 Jun 2021 03:45:32 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Dongbo He has updated the pull request incrementally with one additional >> commit since the last revision: >> >> refactor the code && fix some errors > > src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java > line 133: > >> 131: >> 132: // Check for alias >> 133: Pattern INCLUDE_PATTERN = Pattern.compile( > > You may miss my previous comment. This variable is not static, hence all > capital letters naming does not apply here. > > As you are already here, it may be nice if you'd like to have this variable > as a static final class field. Then, the compile() will be called one time > at most for this class. As a static class field, you could use the > capitalized name. Sorry, I misunderstood what you meant before, I will fix it. Thank you! ------------- PR: https://git.openjdk.java.net/jdk/pull/4424
