On Wed, 14 Jul 2021 19:30:23 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:

> Hi Clive Verghese,
> 
> The performance improve is impressive to me. Would you mind have an 
> additional benchmark for the throughput (@BenchmarkMode(Mode.Throughput))? I 
> guess the throughput should be good as well.
> 
> Thanks!

Sure, I'll add the Throughput mode and run the benchmarks. 

> The benchmark you provided looks a bit odd... In variant 1 best and worst 
> cases differ by 3 ns, and in variant 2 they differ by 45 ns. The algorithm is 
> supposed to be the same, so... Where does the difference come from?

I'll rerun the benchmarks with larger iterations and investigate a bit further 
to understand this difference. Thank you for point it out.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4783

Reply via email to