On Mon, 19 Jul 2021 19:35:16 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated AES-GCM intrinsic to match latest Java Code > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 761: > >> 759: } >> 760: >> 761: dst.put(out, 0, rlen); > > This looks belong to the above if-block? I wonder how this have not affected > the operation to fail. Perhaps the existing regression tests did not cover > the 'rlen < blockSize' case. If the code in the above if-block is not run, > this outsize dst.put(...) call would put extra output bytes into the output > buffer. Yes... this one and the ct offset problem earlier I would have expected the regression test it pick the mistake. There should be tests that catch this.. I'm not sure what's up. ------------- PR: https://git.openjdk.java.net/jdk/pull/4019
