On Mon, 26 Jul 2021 13:37:39 GMT, Sean Mullan <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/x509/X509CertImpl.java line 1924: >> >>> 1922: x -> getFingerprintInternal(x, debug)); >>> 1923: } >>> 1924: >> >> I'm a little confused by these methods. Can you inline >> `getFingerprintInternal` and rename `getFingerprint` on line 1936 to >> `getFingerprintInternal`? > > Not sure what you mean by inline. Do you mean use an anonymous inner class > instead of a lambda for the `Function` argument to > `ConcurrentHashMap.computeIfAbsent`? Note that `getFingerprintInternal` calls > `this.getEncodedInternal` so it cannot be static. It's "inline" in code refactoring. I was thinking about moving the body of the current `getFingerprintInternal` into its only caller above which is also an instance method. IMO, the other `getFingerPrint` on line 1936 is more internal. ------------- PR: https://git.openjdk.java.net/jdk/pull/4891
