On Wed, 4 Aug 2021 02:24:05 GMT, Smita Kamath <svkam...@openjdk.org> wrote:
>> I would like to submit AES-GCM optimization for x86_64 architectures >> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES >> and GHASH operations. >> Performance gain of ~1.5x - 2x for message sizes 8k and above. > > Smita Kamath has updated the pull request incrementally with five additional > commits since the last revision: > > - Merge branch 'aes-gcm' of github.com:smita-kamath/jdk into aes-gcm > - Updates, comment and variable cleanup > - merge rest > - merge > - fixes and code comments src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 1446: > 1444: throw new AEADBadTagException("Input too short - need > tag"); > 1445: } > 1446: Unrelated to your change, but I noticed that the if-block from line 1443-1445 should be moved up before the ArrayUtil.nullAndBoundsCheck(...), otherwise the 3rd argument may be negative and lead to a wrong exception being thrown. ------------- PR: https://git.openjdk.java.net/jdk/pull/4019