On Thu, 19 Aug 2021 19:51:36 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> maxProtocolVersion refactoring
>
> test/jdk/sun/security/ssl/SSLSessionImpl/InvalidateSession.java line 60:
>
>> 58: System.setProperty("javax.net.ssl.keyStorePassword", passwd);
>> 59: System.setProperty("javax.net.ssl.trustStore", trustFilename);
>> 60: System.setProperty("javax.net.ssl.trustStorePassword", passwd);
>
> It is not recommended to use the binary key store files for JSSE test cases.
> Please refer to test/jdk/javax/net/ssl/templates/SSLContextTemplate.java for
> a replacement.
Good suggestion - done.
> test/jdk/sun/security/ssl/SSLSessionImpl/InvalidateSession.java line 173:
>
>> 171: }
>> 172: }
>> 173: }
>
> Is a new line required in the end of file? I see red symbol in the review
> board, I think the symbol may be generated by the GitHub.
not sure it matters, but added a new line
-------------
PR: https://git.openjdk.java.net/jdk/pull/5110
