On Tue, 24 Aug 2021 19:06:37 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> test/jdk/com/sun/crypto/provider/AlgorithmParameters/OAEPOrder.java line 34:
>
>> 32: * @test
>> 33: * @bug 8246797
>> 34: * @summary Ensures OAEPParameters read correct encoding
>
> nit: add "and reject encoding with invalid ordering"
Sure.
> test/jdk/com/sun/crypto/provider/AlgorithmParameters/OAEPOrder.java line 39:
>
>> 37: public class OAEPOrder {
>> 38: public static void main(String[] args) throws Exception {
>> 39: // Do not use default fields
>
> The comment states do not use default fields, but supplies SHA-1 and MGF1SHA1
> below?
Oh no, I keep thinking SHA-256 is the default. Will update to SHA-384.
(Un)fortunately `OAEPParameters.getEncoded()` still encode every fields. That
will be another fix.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5221
