On Mon, 20 Sep 2021 12:04:50 GMT, Weijun Wang <[email protected]> wrote:
>> The test "sun/security/pkcs12/KeytoolOpensslInteropTest.java" performs >> interoperability checks between JDK and openssl with respect to certain >> keystore operations. The test requires a suitable version of openssl to be >> available on the machine it runs. Some mechanisms are used to discover >> openssl, among which searching through a predefined set of paths is also >> one. The test at present looks only at the following absolute paths (in that >> order): > > OK, I understand why the previous 2 paths are not enough. The current change > looks fine to me. > > One small suggestion: since you're are using openssl from $PATH, I assume > it's actually unnecessary to search in `/usr/bin` anymore. Maybe > `/usr/local/bin` is still useful. Yes, I think your suggestion makes sense @wangweij. I will modify the patch today to remove /usr/bin/openssl, do a quick round of testing, and will re-upload. ------------- PR: https://git.openjdk.java.net/jdk/pull/5523
