On Wed, 20 Oct 2021 17:22:38 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Refactoring isValid() for private and public keys
>
> It's a good catch.  Thank you for the fix.

Hi @XueleiFan !
Thank you for review and comments. I've used signum as it is the most 
lightweight method in the BigInteger. Now I have refactored the patch to reuse 
key verification methods from other classes.
isValid() is split out into two methods as you suggested and exception messages 
are updated.
sun/security/rsa tests are passed

-------------

PR: https://git.openjdk.java.net/jdk/pull/4887

Reply via email to