On Tue, 26 Oct 2021 15:42:02 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> src/java.base/share/classes/java/security/KeyStoreSpi.java line 457: >> >>> 455: */ >>> 456: public Set<Entry.Attribute> engineGetAttributes(String alias) { >>> 457: return Collections.emptySet(); >> >> Would `Set.of()` be better here? > > Both returns an internal constant object and I think they are similar. I was > copying the default implementation of `Entry::getAttributes`. Ok. ------------- PR: https://git.openjdk.java.net/jdk/pull/6026