On Mon, 3 Jan 2022 08:53:58 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Hmm, existing test does add an alias, the legacyMap.get() would returns null >> upon 'aliasAlg' (type: String). To test this particular scenario, I enhanced >> existing regression test to re-assign an alias and then check if the >> returned impl is as expected. The proposed test patch is attached. If we are >> including this test patch into this PR, then good to add the bug id to the >> test too. >> [patch.txt](https://github.com/openjdk/jdk18/files/7771389/patch.txt) > > Ping @valeriepeng ^^^ The test update checks that the alias maps to the right algorithm. However, the particular code change covered by this fix is for removing the alias from the previous algorithm which is not triggered by the test change. Alias is an internal property of the Service object. Let me explore more and see if it can be triggered. ------------- PR: https://git.openjdk.java.net/jdk18/pull/70
