On Fri, 18 Feb 2022 20:05:46 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> The enhancement adds two extra items in the `getSubjectAlternativeNames()` 
>> output for an OtherName.
>> 
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` 
>> without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is 
>> suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   make exception message clearer

That's my intent, as the (updated) spec says, only a "valid supported char 
string" is converted, otherwise the raw bytes. The original `makeAltNames` 
method could fail for several reasons, but I don't want the updated one to fail 
for more.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7167

Reply via email to