On Wed, 23 Feb 2022 14:51:45 GMT, Roger Riggs <rri...@openjdk.org> wrote:

> Locale.ROOT is preferred for locale independent uppercase and lowercase().

Yes, as the Locale.English has been used a lot.  It may worthy another 
enhancement to use Locale.ROOT in a separate PR.

> BTW, for the strings written to the SSLLogger, I would have kept the original 
> case intact.

and

> Looks to me like not using toUpperCase in the trace messages would be more 
> efficient and produces shorter code.

Agreed.  I will search for similar code and see if I could have a fix in a 
separate PR.

> The last replace seems a bit strange, I would expect it should first 
> normalize the case and then the hyphen, otherwise it won?t match the replace?

It looks like a bug to me. I would like to keep this PR focus on case issues, 
and may file another PR for this bug.

Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7583

Reply via email to