On Tue, 1 Mar 2022 22:38:30 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:

> May I have this test update reviewed?
> 
> The certificates used in SSL testing template SSLExampleCert could expired in 
> the future (for example 
> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398).  It is not 
> always easy to replace the certificates if the template has been used a lot.
> 
> This update is trying to use a fixed validation date, so that even the 
> certificates are expired the test will continue to work with no surprises.
> 
> I also did a few code clean up in this patch.

test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 26:

> 24: /**
> 25:  * @test
> 26:  * @bug 8806542 8282511

No need to add a bug id here as this is test only change

test/jdk/javax/net/ssl/templates/SSLExampleCert.java line 373:

> 371:         // Set the date for the verifying of certificates.
> 372:         @SuppressWarnings("deprecation")
> 373:         Date verifyingDate = new Date(123, 3, 3);

can DateFormat be used instead to parse Date from a readable string 
representation?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7651

Reply via email to