On Wed, 16 Mar 2022 21:56:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/modules/jdk.charsets/Gensrc.gmk line 32: >> >>> 30: # Generate files using the charsetmapping tool >>> 31: # >>> 32: CHARSET_DATA_DIR := $(TOPDIR)/src/java.base/share/data/charsetmapping >> >> Is it intentional to leave `java.base` literal here, or should it be >> replaced with `$(MODULE_SRC)`? I see this inconsistency in other tools' >> `gensrc.gmk` too > > This is part of the weirdness of charsetmapping that Alan talks about. The > charsetmapping data is shared between java.base and jdk.charsets in a way > that makes it non-trivial to disentangle. > > So this reference to java.base is quite intentional -- replacing it with > $(MODULE_SRC) would have pointed to src/jdk.charsets instead of > src/java.base, which would have been incorrect. Thanks for reminding me. Then yes, I'd agree with Alan. It'd be much simpler to exclude this from this PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/1611
