On Thu, 24 Mar 2022 10:41:18 GMT, Sibabrata Sahoo <ssa...@openjdk.org> wrote:
> Added coverage to logout method.
test/jdk/com/sun/security/auth/module/AllPlatforms.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 8039951 8281717
No need to add bug id here as this is not a product change.
test/jdk/com/sun/security/auth/module/AllPlatforms.java line 44:
> 42: try {
> 43: login("windows", "NTLoginModule", "required");
> 44: login("unix", "UnixLoginModule", "required");
thanks for fixing this code. Test earlier skipped UnixLoginModule early on
"nix" platform as windows login would fail.
test/jdk/com/sun/security/auth/module/AllPlatforms.java line 45:
> 43: UNIX_MODULE, "optional",
> 44: NT_MODULE, "optional");
> 45: login(OS.replaceAll("[^a-zA-Z0-9]", ""),
> getPlatformLoginModule(), "required");
I think test should still be run on all platforms even though login would fail.
On other platforms than the test being run on, test shouldn't fail with
"UnsatisfiedLinkError" as per JDK-8039951.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7940
