On Fri, 8 Apr 2022 20:07:32 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> Please review these changes to update the security libraries to use sealed 
>> classes. See JEP 409 for more details on sealed classes.
>> 
>> No CSR is required as all the changes are to internal classes. A few classes 
>> that did not have subclasses were simply marked final instead of sealed.
>
> Sean Mullan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Make some classes package-private instead of sealed.

Only one comment. Others look fine.

src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsRep.java line 43:

> 41:  * Kerberos client.
> 42:  */
> 43: final class KrbTgsRep extends KrbKdcRep {

Make `KrbAsRep` final also to be symmetric.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8165

Reply via email to