No problem. The code change looks fine to me but you will need to create a CSR. I'll add a comment in the PR.
Thanks, Weijun > On Apr 12, 2022, at 5:37 PM, Mat Carter <matthew.car...@microsoft.com> wrote: > > Weijun > > Here's a PR [1] if you would like to review and consider sponsoring > > [1] https://github.com/openjdk/jdk/pull/8211 > > > Cheers > Mat > > Sent from Outlook > From: Wei-Jun Wang <weijun.w...@oracle.com> > Sent: Monday, April 11, 2022 3:33 PM > To: Mat Carter <matthew.car...@microsoft.com> > Cc: Bernd Eckenfels <e...@zusammenkunft.net>; security-dev@openjdk.java.net > <security-dev@openjdk.java.net> > Subject: Re: Proposal: Extend Windows KeyStore support to include access to > the local machine location > > Added a comment and assigned the enhancement to you. Thanks. > > --Weijun > > > On Apr 11, 2022, at 5:02 PM, Mat Carter <matthew.car...@microsoft.com> > > wrote: > > > > Thanks, Weijun > > > > Let's move ahead with the two new strings while we consider read-only > > access. As the current assignee can you update the JBS issue [1] with what > > we've agreed here. > > > > I have an implementation that I've been testing in 11u which can easily > > move to tip; if you are happy for me to make the changes then please ack > > here and re-assign the issue to me > > > > [1] > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-6782021&data=05%7C01%7CMatthew.Carter%40microsoft.com%7Cf46a1e0bd128483c980f08da1c0b40e6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637853131938100906%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FcdLRJAf8TyNNQjc7Pw9vDBnLNBZ%2BhIjQ17MDMPUqIg%3D&reserved=0 > > > > > > Thanks > > Mat >