On Tue, 19 Apr 2022 16:24:43 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> I ran `codespell` on the `src/java.base` directory, and accepted those 
>> changes where it indeed discovered real typos.
>> 
>> (Due to false positives this can unfortunately not be run automatically) 
>> 
>> The majority of fixes are in comments. A handful is in strings, one in a 
>> local variable name, and a couple in parameter declarations.
>> 
>> Annoyingly, there are several instances of "childs" (instead of "children") 
>> in the source code, but they were not local and I dared not change them. 
>> Someone braver than me might take a stab at it, perhaps..
>
> Magnus Ihse Bursie has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Vertices -> vertices

It's a bit annoying that 3rd party code is not more distinctly handled in the 
JDK source. :( I reverted the code pointed out by reviewers, but then later 
found the ASM code as well.

If I feel really motivated (or bored) I might try to submit PRs with these 
fixes upstream. Or not.

Everybody happy now?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

Reply via email to