On Wed, 27 Apr 2022 23:19:56 GMT, Valerie Peng <valer...@openjdk.org> wrote:

>>> What does it refer to with 'it'? Is 'it' refer to the implementation 
>>> generated parameter values?
>> 
>> 'It' refers to the parameters containing all of the parameter values 
>> including the supplied ones and provider-generated ones if any.
>
> Can you clarify what is the A and B that you are referring to? The way I read 
> it, it has more than 2 conditions... So, best to clarify the conditions 
> first. 
> I see your point with the wording suggestion at the end. Was a bit lost when 
> trying to go through the various if-else logic and figure out what you mean...

With Signature class, there is a caveat for EdDSA, the supplied parameters are 
set but null is being returned when getParameters() is called. This is 
currently covered by the condition `if the underlying signature implementation 
supports returning the parameters as {@code AlgorithmParameters}` as the 
underlying signature does not support AlgorithmParameters for the supplied 
EdDSAParameterSpec object due to lack of ASN.1 definition.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8396

Reply via email to