On Mon, 2 May 2022 05:01:21 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> comment about remove finalize() method
src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java line 44:
> 42: * overridden in SSLSocketImpl.
> 43: *
> 44: * There used to be a finalize() implementation, but decided that was
Since you haven't pushed yet, maybe:
There used to be a finalize() implementation that sent close_notify's, but
decided that was not needed. An application should close its sockets and not
let them get garbage collected without closing them.
The underlying native resources are handled by the Socket Cleaner.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8065
