On Tue, 10 May 2022 13:07:02 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> @wangweij - regarding the two tests for localmachine, these will throw a >> KeyStore exception "Access denied" if the test is not run as admin, is there >> anyway in the test to make that a requirement? If so we could split into >> two tests, one in admin that does all and one in non-admin that does the >> currentuser tests > > @macarte You need to finalize your CSR soon if you want to include this > change into JDK 19. RDP1 is 2022/06/09, and all enhancements require approval > after that. > > BTW, is it possible to detect whether you have admin privilege inside the > test? There is a `NTSystem` class inside Java which can find out user info. > Maybe the `getGroupIDs()` method will tell you if you are an admin? > > We can enhance the test before RC. @wangweij - I added your test and updated to handle Access Denied errors due to admin rights missing, in this case we ignore the test The CSR has been finalized and I feel we are ready to close out this PR ------------- PR: https://git.openjdk.java.net/jdk/pull/8211
