On Wed, 11 May 2022 14:57:16 GMT, Claes Redestad <redes...@openjdk.org> wrote:
> #8599 would add a new warning. This address the conversions in the
> microbenchmark component by means of making the types precise or adding
> explicit casts. There's quite a few changes in the ByteBuffers benchmarks,
> but the real change is in the template as these are generated.
>
> I've run through a subset of the affected benchmarks and verified that the
> results are either neutral or improve somewhat (seem to be the case in a few
> of the ByteBuffer micros).
I have questions. Also, copyright dates are not consistently updated in
affected files?
test/micro/org/openjdk/bench/vm/compiler/PointerBenchmarkFlat.java line 151:
> 149: int sum = 0;
> 150: for (int i = 0 ; i < ELEM_SIZE ; i++) {
> 151: sum += (int)ptr_ptr.get(i).address().toRawLongValue();
Here and later: `toRawLongValue` returns `long`, right? So why don't we change
the accumulator and return value to `long`, like we do in other tests?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8654
