On Thu, 28 Jul 2022 01:37:07 GMT, Weijun Wang <[email protected]> wrote:
>> Add an `@implNote` to clarify the behavior when these methods are called. A
>> new test is added.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Brad comment
Take or leave.
Otherwise LGTM.
src/java.base/share/classes/java/security/DigestInputStream.java line 57:
> 55: * with data actually read from the input stream when it is turned
> on.
> 56: * This includes the various {@code read} methods, {@code
> transferTo},
> 57: * {@code readAllBytes}, and {@code readNBytes}. Especially, data
Maybe just "Note" instead of "Especially" (or just remove) as this doesn't seem
to be an extra special situation.
-------------
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9667
