On Fri, 29 Jul 2022 20:01:56 GMT, Kevin Driver <[email protected]> wrote:
>> As mentioned in the bug report, this issue *should not* be a framework-level
>> issue, since potentially an individual provider could create a keysize of
>> zero to have a certain significance.
>>
>> In the changes made here for `HmacMD5`- and `HmacSHA1`- `KeyGenerator`s, the
>> check is for `keysize <= 0` and this message indicates this is a check
>> characteristic to the `SunJCE` provider.
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> put back standard if block, since we never hit the failure case
Marked as reviewed by wetmore (Reviewer).
test/jdk/com/sun/crypto/provider/KeyGenerator/Test6227536.java line 50:
> 48:
> 49: public static void main(String[] args) throws Exception {
> 50: Test6227536 test = new Test6227536();
Calling the constructor just to get the class name seems redundant, as the test
name will appear in all of the jtreg test output. I would probably pull it
out, just my $0.02.
-------------
PR: https://git.openjdk.org/jdk/pull/9679
