On Wed, 10 Aug 2022 16:10:02 GMT, Bernd <d...@openjdk.org> wrote:

>> I think if you just said "If this properties file ..." it would be 
>> sufficient, as the previous paragraph provided enough context as to what you 
>> are referring to.
>
> Btw the current code does not handlmissing or unreadable overwrite files very 
> well. PropsLoaded will be true even when the replacing overwrite file could 
> not be loaded (resulting in an empty list).

it's a fair point @ecki -- the 2nd `loadedProps = true;` call is redundant 
since the code block is not executed unless the 
`security.overridePropertiesFile` is set to true by reading the props from 
default/master file.

one option here might be to delay the re-initialization of `props` until we 
successfully load the override security props file

i.e. push this code block down 

            if (overrideAll) {
                props = new Properties();
                if (sdebug != null) {
                    sdebug.println
                        ("overriding other security properties files!");
                }
            }


I'll log another JBS issue to track that.

-------------

PR: https://git.openjdk.org/jdk/pull/9747

Reply via email to