On Thu, 18 Aug 2022 11:48:01 GMT, Jayashree Huttanagoudar <d...@openjdk.org> wrote:
>> Could you please review the changes? >> This patch is to address : >> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug > > Jayashree Huttanagoudar has updated the pull request with a new target base > due to a merge or a rebase. The pull request now contains 14 commits: > > - Merge branch 'master' into JDK-8215916 > - Address errors by bot to the previous commit > - Address review comment > - Address whitespace error by jcheck > - Address whitespace error by jcheck > - Address review comment to add call stacktrace changes to OPTIONAL login > module when debug is on > - Address review comment to revert back the previous changes in the test case > - Address review comment for cross-platform in the test case > - Address review comment for test case > - Added test case using {Unix,NT}LoginModule > - ... and 4 more: https://git.openjdk.org/jdk/compare/f2773f64...93a22f7a test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java line 87: > 85: if (s.contains("Failed in attempt to import the underlying")) { > 86: System.out.printf("-- call stack is -- %n%s%n", s); > 87: } To make this a test, it should fail when the string is not found. ------------- PR: https://git.openjdk.org/jdk/pull/9159