On Tue, 6 Sep 2022 14:40:42 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more refactoring. > > test/jdk/java/security/Security/ProviderFiltering.java line 108: > >> 106: doit(key + ":" + valComp1, p); >> 107: doit(key + ":" + valComp2, p); >> 108: doit(key + ":" + valComp2CN); > > Please provide a comment on `valComp2CN`. Ok. > test/jdk/java/security/Security/ProviderFiltering.java line 145: > >> 143: doit(filters, pName); >> 144: >> 145: // should find no proviser now that TestProv is removed > > Typo, `s/proviser/provider/`. Will fix, thanks~ ------------- PR: https://git.openjdk.org/jdk/pull/10008