On Tue, 25 Oct 2022 13:51:06 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 11 commits: >> >> - blessed modifiers >> - Merge branch 'master' into 8292033-x509Event >> - restore import style >> - Merge branch 'master' into 8292033-x509Event >> - Minor clean up >> - Merge branch 'master' into 8292033-x509Event >> - update commit method name >> - Record all X509 generate events >> - fix up merge >> - merge with master >> - ... and 1 more: https://git.openjdk.org/jdk/compare/f37a6055...c58e0fa6 > > test/lib/jdk/test/lib/security/TestCertificate.java line 45: > >> 43: ONE("1000", >> 44: "CN=SSLCertificate,O=SomeCompany", >> 45: "CN=Intermediate CA Cert,O=SomeCompany", > > Why remove the spaces? `X500Name::toString` always has them. Code was modified to use the X509Certificate API (rather than X509CertImpl) it's using the X500Principal#getName() call now. Would it be better to use X500Principal#toString() ? ------------- PR: https://git.openjdk.org/jdk/pull/10422