On 10/31/22 11:02 AM, Mark Powers wrote:
On Mon, 10 Oct 2022 21:04:46 GMT, Sean Mullan <mul...@openjdk.org> wrote:

Mark Powers has updated the pull request incrementally with one additional 
commit since the last revision:

   Sean comments

test/jdk/javax/security/auth/PrivateCredentialPermission/Serial2.java line 35:

33: import java.util.*;
34:
35: public class Serial2 implements java.io.Serializable {

I don't see why this needs to implement `Serializable` (I see you probably used 
the other `Serial.java` test in this directory as a template. I don't think 
that needs it either, but you can leave that as is for now).

I read your sentence as "leave both for now". Sorry. You mean fix in this PR 
and leave the other alone.

Yes, I meant remove it from this test if it isn't needed. I think you can fix the other one, if you like, but since it hasn't caused any issues, feel free to leave it for now.

--Sean

Reply via email to