On Mon, 31 Oct 2022 18:26:25 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> same for DerEncoder::derEncode
>>
>> only in patch2:
>> unchanged:
>
> src/java.base/share/classes/sun/security/pkcs10/PKCS10Attributes.java line 96:
>
>> 94: * @exception IOException on encoding errors.
>> 95: */
>> 96: public void encode(DerOutputStream out) throws IOException {
>
> Add `@Override`.
I think you are missing `@Override` on some of the other `encode` and
`derEncode` methods.
-------------
PR: https://git.openjdk.org/jdk/pull/10906
